Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Fix npm audit #4308

Closed

Conversation

nextcloud-command
Copy link
Contributor

Auto-generated fix of npm audit

@nextcloud-command nextcloud-command added 3. to review dependencies Pull requests that update a dependency file labels Jun 18, 2023
@cypress
Copy link

cypress bot commented Jun 18, 2023

Passing run #10262 ↗︎

0 51 0 0 Flakiness 0

Details:

Merge fcb0469 into e7ab87e...
Project: Text Commit: c504ae2571 ℹ️
Status: Passed Duration: 02:26 💡
Started: Jun 19, 2023 4:27 PM Ended: Jun 19, 2023 4:29 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo-
Copy link
Member

mejo- commented Jun 19, 2023

stable24 is end of life. I opened #4311 to prevent updates to stable24.

@mejo- mejo- closed this Jun 19, 2023
@juliushaertl juliushaertl reopened this Jun 19, 2023
@juliushaertl
Copy link
Member

/compile

Signed-off-by: nextcloud-command <[email protected]>
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, something went wrong here. The commit by nextcloud-command only touches the compiled assets, not package-lock.json. And the compile commit reverts this 🤪

@juliushaertl
Copy link
Member

Damn, let me check locally what is going wrong there

@juliushaertl
Copy link
Member

Seems totally fine locally:


up to date, audited 1591 packages in 3s

182 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

@szaimen Have you seen something like this since you worked on the github action for updating the audit fix?

Let me close this for now.

@szaimen
Copy link
Contributor

szaimen commented Jun 19, 2023

@szaimen Have you seen something like this since you worked on the github action for updating the audit fix?

No, not yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants