Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/2708 pasting tables #4285

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Fix/2708 pasting tables #4285

merged 3 commits into from
Jun 19, 2023

Commits on Jun 19, 2023

  1. fix: only load CodeBlock extension without CodeBlockLowlight 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud @mejo-
    max-nextcloud authored and mejo- committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    69d5889 View commit details
    Browse the repository at this point in the history

  2. fix: paste tables into document 

    Fixes #2708.

Try to read the first table row as headings.

Pasting works via `insertContent` while opening uses `setContent`.
They use the schema in different ways.
So we also need to make sure to test both for some corner cases.

`setContent` is fairly flexible in turning the input
into a valid document structure.
`insertContent` however fails to resolve structures
that would require picking lower priority parent elements.

Note: Some tests in src/tests/nodes/Table.spec.js
fail when using `insertContent` instead of `setContent`.
Pasting the correponding html table is fixed never the less.

Signed-off-by: Max <[email protected]>
    @max-nextcloud @mejo-
    max-nextcloud authored and mejo- committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    92a3dcf View commit details
    Browse the repository at this point in the history

  3. chore(assets): Recompile assets 

    Signed-off-by: nextcloud-command <[email protected]>
    @nextcloud-command
    nextcloud-command committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    c485bf0 View commit details
    Browse the repository at this point in the history