Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded images not loaded inside iOS Notes app #5419

Closed
pjft opened this issue Feb 27, 2024 · 1 comment
Closed

Embedded images not loaded inside iOS Notes app #5419

pjft opened this issue Feb 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@pjft
Copy link

pjft commented Feb 27, 2024

Describe the bug
Attachments no longer opening on iOS app, with error 500.

To Reproduce
Steps to reproduce the behavior:

  1. Open note with attachments.

Expected behavior
Attachments render as expected.

Screenshots
unnamed (6)

Server details:

  • Nextcloud version: 27.1.6
  • PHP Version: 8.2.7
  • Database: MySQL

Client details:

  • OS: iOS, NextCloud app 5.2.0.2
  • Device: iPhone 14
Logs

Nextcloud log (data/nextcloud.log)

[index] Error: Exception: Call to a member function getUID() on null in file '/var/www/html/nextcloud/apps/text/lib/Service/AttachmentService.php' line 434 at <>

  1. /var/www/html/nextcloud/lib/private/AppFramework/App.php line 183
    OC\AppFramework\Http\Dispatcher->dispatch()
  2. /var/www/html/nextcloud/lib/private/Route/Router.php line 315
    OC\AppFramework\App::main()
  3. /var/www/html/nextcloud/lib/base.php line 1068
    OC\Route\Router->match()
  4. /var/www/html/nextcloud/index.php line 38
    OC::handleRequest()

Caused by:

Error: Call to a member function getUID() on null at <>

  1. /var/www/html/nextcloud/apps/text/lib/Service/AttachmentService.php line 226
    OCA\Text\Service\AttachmentService->getAttachmentDirectoryForFile()
  2. /var/www/html/nextcloud/apps/text/lib/Controller/AttachmentController.php line 101
    OCA\Text\Service\AttachmentService->getAttachmentList()
  3. /var/www/html/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 230
    OCA\Text\Controller\AttachmentController->getAttachmentList()
  4. /var/www/html/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 137
    OC\AppFramework\Http\Dispatcher->executeController()
  5. /var/www/html/nextcloud/lib/private/AppFramework/App.php line 183
    OC\AppFramework\Http\Dispatcher->dispatch()
  6. /var/www/html/nextcloud/lib/private/Route/Router.php line 315
    OC\AppFramework\App::main()
  7. /var/www/html/nextcloud/lib/base.php line 1068
    OC\Route\Router->match()
  8. /var/www/html/nextcloud/index.php line 38
    OC::handleRequest()

POST /index.php/apps/text/attachments

Likely related to the changes from 3 months ago:
https://github.com/nextcloud/text/commits/main/lib/Service/AttachmentService.php

Unsure if client or server issue, hence cross-posting the bug. Apologies if incorrect.

Thanks.

@pjft pjft added the bug Something isn't working label Feb 27, 2024
@joshtrichards
Copy link
Member

Fixed in 5707c21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants