Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV]: missing labels on textaria inside of translate modal dialog #5221

Closed
JuliaKirschenheuter opened this issue Jan 10, 2024 · 3 comments · Fixed by #5234
Closed

[BITV]: missing labels on textaria inside of translate modal dialog #5221

JuliaKirschenheuter opened this issue Jan 10, 2024 · 3 comments · Fixed by #5234
Assignees
@luka-nextcloud
Labels
3. to review a11y28checked needed for a11y accessibility help wanted Extra attention is needed

Comments

@JuliaKirschenheuter
Copy link
Contributor

Screenshot from 2024-01-10 10-19-03

Please adapt label for the textaria, NcTextArea component

Please check other places on existing label's.
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jan 10, 2024
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Jan 10, 2024
@luka-nextcloud
Copy link
Contributor

@JuliaKirschenheuter @juliushaertl Got it, what could be the texts for the labels of textarea elements?
"Input" and "Output"?

@juliusknorr
Copy link
Member

Maybe "Text to translate from" "Translated text result" to be a bit less technical

@luka-nextcloud luka-nextcloud moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Jan 11, 2024
@luka-nextcloud luka-nextcloud mentioned this issue Jan 11, 2024
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Jan 26, 2024
@szaimen
Copy link
Contributor

szaimen commented Feb 2, 2024

I cannot test this but the backport seems to be merged

@szaimen szaimen added the a11y28checked needed for a11y label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luka-nextcloud luka-nextcloud

Labels
3. to review a11y28checked needed for a11y accessibility help wanted Extra attention is needed
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add labels to textarea elements in translate modal nextcloud/text
4 participants
@juliusknorr @JuliaKirschenheuter @szaimen @luka-nextcloud