Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] list items are too separated in a list #4547

Closed
87113 opened this issue Jul 14, 2023 · 4 comments · Fixed by #4596
Closed

[UI] list items are too separated in a list #4547

87113 opened this issue Jul 14, 2023 · 4 comments · Fixed by #4596
Assignees
Labels
bug Something isn't working design Experience, interaction, interface, …

Comments

@87113
Copy link

87113 commented Jul 14, 2023

Describe the bug
The items are visually too separated in list

To Reproduce
Steps to reproduce the behavior:

  1. write a list with some items

Expected behavior
The list items should be compact enough to help the user to see that is the same list.

In the html the content of the <li> is inside a <p> and a <div> each of them with a pretty big margin-bottom.
If this margin are disabled the space between list item is perfect.

Screenshots

actual style

Capture d’écran du 2023-07-14 15-21-13

What I think is better

Capture d’écran du 2023-07-14 15-21-44

@87113 87113 added the bug Something isn't working label Jul 14, 2023
@juliusknorr
Copy link
Member

@jancborchardt I think this was on purpose when we did the text app formatting css in the beginning, but can you double check this one?

@Ornanovitch
Copy link

I totally agree with @87113, I never understood this huge gap between list elements :/

@mejo-
Copy link
Member

mejo- commented Jul 19, 2023

I agree that list items are too much separated at the moment - they always appear as separate lists to me. Thanks @87113 for looking into this.

I'll transfer the issue to the Nextcloud Text app as it needs to be addressed there.

@mejo- mejo- transferred this issue from nextcloud/collectives Jul 19, 2023
@mejo- mejo- added the design Experience, interaction, interface, … label Jul 19, 2023
@jancborchardt
Copy link
Member

It actually seems like a bug? Currently the padding-bottom: 1em; from p .paragraph-content is taken, but the li p { padding-bottom: 0.5em; } is correct.

So yes, I’m fine with shortening this in lists to 0.5em, but make sure that it doesn’t break the case where 1em is wanted, like for paragraphs.

mejo- added a commit that referenced this issue Jul 28, 2023
Fixes: #4547

Required after 774a42b.

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- self-assigned this Jul 28, 2023
mejo- added a commit that referenced this issue Jul 28, 2023
Fixes: #4547

Required after 774a42b.

Signed-off-by: Jonas <[email protected]>
mejo- added a commit that referenced this issue Jul 28, 2023
Fixes: #4547

Required after 774a42b.

Signed-off-by: Jonas <[email protected]>
backportbot-nextcloud bot pushed a commit that referenced this issue Jul 28, 2023
Fixes: #4547

Required after 774a42b.

Signed-off-by: Jonas <[email protected]>
backportbot-nextcloud bot pushed a commit that referenced this issue Jul 28, 2023
Fixes: #4547

Required after 774a42b.

Signed-off-by: Jonas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design Experience, interaction, interface, …
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants