You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When the name/title of a page contains a '#' character, image attachments cannot be loaded after saving.
To Reproduce
Steps to reproduce the behavior:
Create a new markdown file containing a '#' in its title/name
Attach an image, e.g. by pasting one from the clipboard
The image is displayed while still editing the file
Click the 'Done' button
The image is replaced by a 404 error box
Expected behavior
The image should be displayed all the time.
Screenshots
Create page containing '#' in name:
View after saving image:
View after replacing '#' with 'No.' and reloading/reselecting the page
From the developer tool in Firefox I gathered the following:
The Image loaded by collective-main.js contains an unescaped '#' character: [redacted]/Collectives/Instruments/Guitars/Heritage%2025th%20Anniversary%20C150%20#16%20(02-22-2010)/.attachments.460129/image.png
Client details:
OS: macOS 13.2
Browser: Firefox
Version: 112.0.2
Device: MacBook Air
Server details
Collectives app version: 2.4.0
Operating system: Debian bullseye
Web server: nginx
Database: mariadb
PHP version: 8.2
Nextcloud version: 26.0.1
I don't think that any further logs should be required but I am happy to deliver them in case they are.
The text was updated successfully, but these errors were encountered:
As far as I tried to understand it, the problem is that with the readonly editor, we will request the file via DAV. And there, the # is not escaped in the filename when doing the request for some reason.
Describe the bug
When the name/title of a page contains a '#' character, image attachments cannot be loaded after saving.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The image should be displayed all the time.
Screenshots
Create page containing '#' in name:
View after saving image:
View after replacing '#' with 'No.' and reloading/reselecting the page
From the developer tool in Firefox I gathered the following:
The Image loaded by collective-main.js contains an unescaped '#' character:
[redacted]/Collectives/Instruments/Guitars/Heritage%2025th%20Anniversary%20C150%20#16%20(02-22-2010)/.attachments.460129/image.png
Client details:
Server details
Collectives app version: 2.4.0
Operating system: Debian bullseye
Web server: nginx
Database: mariadb
PHP version: 8.2
Nextcloud version: 26.0.1
I don't think that any further logs should be required but I am happy to deliver them in case they are.
The text was updated successfully, but these errors were encountered: