Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve read only performance when just displaying rich workspace #2183

Open
juliushaertl opened this issue Feb 15, 2022 · 4 comments · Fixed by #2226
Open

Improve read only performance when just displaying rich workspace #2183

juliushaertl opened this issue Feb 15, 2022 · 4 comments · Fixed by #2226

Comments

@juliushaertl
Copy link
Member

In most cases the rich workspace area is probably not edited, so we should think about having a more sane process for opening up a read only editor and just kicking of the heavy sync parts and session setup when starting to edit.

@max-nextcloud
Copy link
Collaborator

I profiled the workspace loading some and it turns out rendering the menubar is surprisingly expensive.
I experimented some with it and we can postpone that until the content has been rendered. In theory this would reduce the time till the content is displayed by 600-800ms. In practice it's still hard to measure.

@ImaCrea
Copy link

ImaCrea commented Mar 8, 2022

Great idea :) It's very disturbing when I'm ready to click on a file and then everything scrolls down because finally the editor is loaded. At least having a placeholder before it's loaded so elements doesn't move when editor is loaded would be an improvement.

@tcitworld
Copy link
Member

tcitworld commented Nov 24, 2023

The PR from @max-nextcloud doesn't really answer the original issue, may this issue be reopened to avoid loading sync & session until the workspace is actually opened (to avoid make the backend work for nothing) ?

@max-nextcloud max-nextcloud reopened this Dec 1, 2023
@juliushaertl
Copy link
Member Author

#4776 also contributed to that by showing the content already before the session is opened but what would be missing is a read only and just open the session once clicked option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants