Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Voice recording #1786

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rapterjet2004
Copy link

@rapterjet2004 rapterjet2004 commented Aug 30, 2024

Current Demo

issue-618-1.mov

ToDo

  • Added a voice recording lock button
  • Added a new SwiftUI View for expanded voice recording
  • Stop AVAudioRecorder from ending and implement the send, delete, stop/restart buttons

- Added a voice recording lock button
- Added a new SwiftUI View for expanded voice recording
@rapterjet2004 rapterjet2004 marked this pull request as ready for review September 6, 2024 15:12
Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rotating the screen breaks the UI:
Simulator Screenshot - iPhone 15 Pro - 2024-09-08 at 20 36 42

Also I noticed that the buttons are not clickable in the bottom area?! 🤔

Please also take care of the swiftlint warnings :)

NextcloudTalk/BaseChatViewController.swift Show resolved Hide resolved
NextcloudTalk/BaseChatViewController.swift Show resolved Hide resolved
NextcloudTalk/BaseChatViewController.swift Show resolved Hide resolved
@SystemKeeper
Copy link
Collaborator

Really nice work otherwise, thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting rid of the need to keep the record button pressed for voice messages
2 participants