Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added username and timestamp on media viewer controller #1728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aniketbhondave
Copy link

What type of PR is this?

  • 📦 Enhancement
  • [] 📦 Change Issue Type
  • [] 🐛 Bug Fix
  • [] 📦 Fix Version

Description

On media viewer page showing the details of user who has uploaded the image and time stamp of uploaded image

Related Tickets & Documents

#1703

Mobile Screenshots/Recordings

Before:
Screenshot 2024-07-25 at 8 05 20 PM

After:
image

Added tests?

  • 👍 Manual Tested

Copy link

github-actions bot commented Aug 9, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@SystemKeeper
Copy link
Collaborator

Hello and welcome 👋
Thank you very much for your Pull Request. Sorry it took so long from our side to take a look :-(.

Some comments about your PR:

  • To have a PR in a mergable state, we would need your commits be signed-off (DCO)
  • Instead of replacing the titleview we would actually want to have the information on a view below the navigation bar
  • Currently you use fixed values for sizes (e.g. font size) and alignments. That should be done by using text styles (see
    textView.font = .preferredFont(forTextStyle: .body)
    for example) and use AutoLayout to be positioned correctly. This ensures that it works fine on different devices, accessibility settings, device orientations, etc.
  • For format dates and/or times we have some helper methods in NCUtils, take a look if something from there already works for your case or add a new method you need.

Let me know if you need more details and if you would like to continue to work on that PR 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants