Test with 23 #1372
Merged
Test with 23 #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SystemKeeper
force-pushed
the
test-with-24
branch
from
2eb2af0
to
058c079
Compare
|
Well, since 23 does not support reactions, it fails anyway -,- will take a look |
SystemKeeper
force-pushed
the
test-with-24
branch
2 times, most recently
from
26fe798
to
48c491f
Compare
Ivansss
requested changes
Sep 26, 2023
SystemKeeper
force-pushed
the
test-with-24
branch
from
48c491f
to
d2ed1c4
Compare
|
Tests failing because of d0d369c is merged |
|
#1375 merged :) |
Signed-off-by: Marcel Müller <[email protected]>
Signed-off-by: Marcel Müller <[email protected]>
Signed-off-by: Marcel Müller <[email protected]>
Signed-off-by: Marcel Müller <[email protected]>
SystemKeeper
force-pushed
the
test-with-24
branch
from
d2ed1c4
to
820b100
Compare
|
Rebased and tests passed :) |
Ivansss
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The run on 23 without the patch for the participantFlags fails as expected: https://github.com/nextcloud/talk-ios/actions/runs/6273738989/job/17037766340
So I would suggest we add 23 to our test matrix to catch any issues with older versions