Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust placeholder view constraints to safe area #1301

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Adjust placeholder view constraints to safe area #1301

merged 1 commit into from
Jul 18, 2023

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Jul 12, 2023

No description provided.

@SystemKeeper
Copy link
Collaborator

image

🤔

@Ivansss
Copy link
Member Author

Ivansss commented Jul 14, 2023

I couldn't find an easy fix for this problem, not as trivial as I thought.
This PR fixes the positioning of the activity indicator.
This issue of the screenshot above is tracked here #1290 and we can try to fix it in a follow-up PR.

@SystemKeeper
Copy link
Collaborator

This issue of the screenshot above is tracked here #1290 and we can try to fix it in a follow-up PR.

Sorry, I though that should be the fix for exactly that…

SystemKeeper
SystemKeeper approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I know what I should test, this works as expected ;)

@SystemKeeper SystemKeeper merged commit 0e8ac79 into master Jul 18, 2023
@SystemKeeper SystemKeeper deleted the adjust-placeholder-view-constraints branch July 18, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ivansss @SystemKeeper