Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially fix intent crash #1297

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Potentially fix intent crash #1297

merged 1 commit into from
Jul 10, 2023

Conversation

SystemKeeper
Copy link
Collaborator

We got a few reports about a crash in donateSendMessage from TestFlight. I am not sure how this can happen and I am unable to reproduce locally. Two things

  1. Split the image part to 2 lines, so we know which call fails if it fails in the future
  2. Make sure to do the donation before dismissing the share view (should probably have a completion block, but as a first step this makes sense)

@Ivansss Ivansss merged commit 6126255 into master Jul 10, 2023
4 checks passed
@Ivansss Ivansss deleted the fix-intent-crash branch July 10, 2023 16:08
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants