Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: monochrome tray icon #836

Merged
merged 3 commits into from
Oct 23, 2024
Merged

feat: monochrome tray icon #836

merged 3 commits into from
Oct 23, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 21, 2024

One of the PRs, continuing #835

☑️ Resolves

🖼️ Screenshots

image

Handle system theme change without reload

tray-icon-change

@ShGKme ShGKme added bug Something isn't working enhancement New feature or request 3. to review labels Oct 21, 2024
@ShGKme ShGKme self-assigned this Oct 21, 2024
@ShGKme ShGKme marked this pull request as ready for review October 23, 2024 08:28
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, tested on Win

@@ -58,6 +59,10 @@ function relaunch() {
{{ t('talk_desktop', 'Theme') }}
</SettingsSelect>

<NcCheckboxRadioSwitch :checked.sync="monochromeTrayIcon" type="switch">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires a restart for me to take effect

Copy link
Contributor Author

@ShGKme ShGKme Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now, you can merge)

@ShGKme ShGKme enabled auto-merge October 23, 2024 10:22
@ShGKme ShGKme merged commit 3bfe63b into main Oct 23, 2024
10 checks passed
@ShGKme ShGKme deleted the feat/monochrome-tray-icon branch October 23, 2024 10:23
This was referenced Oct 27, 2024
@ShGKme ShGKme mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants