Migration away from getScheme() calls

[rapterjet2004]

fixes #3042

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[rapterjet2004]

@AndyScherzinger @AlvaroBrey
I'm not familiar with android common. Is there any reason why in ColorRole(internal val select: (Scheme) -> Int) the select function is internal? It would be helpful to use this functionality in TalkSpecificViewThemeUtils, as it enables the selection of colors without accessing the scheme directly. I wouldn't want to copy the same enum class in this project.

[AndyScherzinger]

@rapterjet2004 for which theming call would you actually need it? Or why not use the scheme?

[rapterjet2004]

@AndyScherzinger in com.nextcloud.talk.utils.message.MessageUtils the enrichChatReplyMessageText takes in a textColor: Int as it's parameter. The color passed is not always the same with it sometimes being R.color.nc_incoming_text_default and at other times being viewThemeUtils.getScheme(context).onSurfaceVariant.

I didn't want to hardcode any solution, so I figured that it would be best to use a ColorRole like they did in android commons.

[AndyScherzinger]

Well, you could hard-code it because it is Talk specific. I guess one is incoming messages and the other is outgoing messages? So from a theming perspective one could argue that you actually want two distinct methods to reflect the theming by having "business functions", less generic, not specific and by name clear when to use which one.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3235-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!