Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Notifier #889

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

refactor: Notifier #889

wants to merge 3 commits into from

Conversation

joshtrichards
Copy link
Member

Some refactoring + swap out of InvalidArgumentException() with UnknownNotificationException() where appropriate

@joshtrichards
Copy link
Member Author

joshtrichards commented Jul 11, 2024

I guess we should change the label provided to setLabel() to not be the translated one too... it may fix #877

Refs:
nextcloud/spreed#11610
nextcloud/server#43691

Signed-off-by: Josh <[email protected]>
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant