Reduce log messages when no model found #869
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlap
changed the title
victorlap
force-pushed
the
reduce-log-messages-when-no-model
branch
2 times, most recently
from
0a07172
to
898cf95
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
st3iny
reviewed
May 11, 2024
Signed-off-by: Victor Lap <[email protected]>
Signed-off-by: Victor Lap <[email protected]>
Co-authored-by: Richard Steinmetz <[email protected]> Signed-off-by: Victor <[email protected]>
susnux
force-pushed
the
reduce-log-messages-when-no-model
branch
from
b2a6d71
to
8050aa5
Compare
susnux
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #793.
I've separated the fact that a model could not be found from the other possible service exceptions. When such a case is found, it now only logs to the debug log. This might technically be duplicate, but I think it's good to include anyways for debugging purposes.