Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubixML #780

Open
enoch85 opened this issue Mar 30, 2023 · 15 comments
Open

Update rubixML #780

enoch85 opened this issue Mar 30, 2023 · 15 comments
Labels
bug Something isn't working

Comments

@enoch85
Copy link
Member

enoch85 commented Mar 30, 2023

Current version of suspicious login makes Recognize fail: nextcloud/recognize#676

To solve this rubixML should be updated according to the Recognize dev.

@ChristophWurst
Copy link
Member

It only fixes the issue temporarily. This is not a fix.

@enoch85
Copy link
Member Author

enoch85 commented Mar 30, 2023

OK, it's out of my league, just the messenger here. :) I'm sure you can come up with something better.

@AndyXheli
Copy link

Also having this issue. My Nextcloud Server log gets spamed with these error. @ChristophWurst can we at least appy a temp fix until a better fix it in place ?

image

@ChristophWurst
Copy link
Member

Sure, give it a try

@vasyugan
Copy link

so far, the only working fix seems to be disabling one of the two apps, which is really inconvenient.

@frederickjansen
Copy link

Why is the version of RubixML in this repo set to dev-chore/bump-flysystem-v2.1.1? Before that it relied on an old version of RubixML, 0.3 or 0.4.
Not sure why updating that dependency to 2.x isn't considered to be a proper fix. It's an incompatible dependency at the moment. Unless you're saying that Nextcloud needs to revamp their plugin system so that individual plugins are sandboxed and can rely on older dependencies that are incompatible with other plugins.

@ChristophWurst
Copy link
Member

Unless you're saying that Nextcloud needs to revamp their plugin system so that individual plugins are sandboxed and can rely on older dependencies that are incompatible with other plugins.

Technically not doable with the way PHP handles namespaces.

@flintman
Copy link

It only fixes the issue temporarily. This is not a fix.

So what is the fix for this, given this was brought up in March and here we are in July and its still an issue. I can't use both apps at the same time which tells me, why does Nextcloud say they are official apps? I'd get it if one was official and the other isn't.

@SuperSandro2000
Copy link

5.0.0 was already tagged a while ago but never pushed to the store

@ChristophWurst
Copy link
Member

The same as https://github.com/nextcloud/twofactor_totp#nextcloud-25-and-newer applies to this app. It is shipped and no longer distributed via the app store.

@SuperSandro2000
Copy link

I wasn't aware of that. This should probably be written into the README and the store page so that people are aware that they can uninstall it.

@ChristophWurst
Copy link
Member

They can't uninstall it. It's shipped.

@SuperSandro2000
Copy link

Sorry, I was a bit unclear. For me the app was still installed in the apps directory where all downloaded apps from the app store are located. After deleting that, so far things are working as expected.

@bugsyb
Copy link

bugsyb commented Oct 20, 2023

5.0.0 was already tagged a while ago but never pushed to the store

Would it be sufficient to pull v5 from github and push to the NC apps folder? If this would fix the problem - can this be pushed to the NC store? If this is not possible, would be good to understand why, as maybe it shouldn't be then used on our installs either.

Thanks! Suspicious Login app is great and much needed.

@marcelklehr
Copy link
Member

Just to weigh in. Putting rubix in a "mozart jail" doesn't work due to bugs in mozart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants