Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make useIsInCall a shared composable #13737

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 8, 2024

☑️ Resolves

  • Fix creating a separate composable instance for each component it uses

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
2024-11-08_14h33_38 2024-11-08_14h35_46

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

@Antreesy
Copy link
Contributor Author

Antreesy commented Nov 8, 2024

/backport to stable30

@Antreesy
Copy link
Contributor Author

Antreesy commented Nov 8, 2024

/backport to stable30.0

@Antreesy Antreesy merged commit 8e5c7f9 into main Nov 8, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/use-is-in-call-shared branch November 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants