Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(Call): introduce intermediary phase before joining call #13735

Merged
merged 10 commits into from
Nov 13, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 8, 2024

Backport of #13329

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added this to the 🌠 Next Minor (30) milestone Nov 8, 2024
@DorraJaouad DorraJaouad marked this pull request as ready for review November 10, 2024 21:23
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅ but good to have it tested two times @Antreesy

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with 3 ppl in Talk call, Files Sidebar, Public Share Sidebar

src/services/callsService.js Outdated Show resolved Hide resolved
…t. It's only received when using internal server. Replace them with events from the base class so we make sure it's always received. Also, add a new event for failed joining

Signed-off-by: DorraJaouad <[email protected]>
…nCall, connecting, connection failed)

Signed-off-by: DorraJaouad <[email protected]>
…roduce a failed join message dialog.

Signed-off-by: DorraJaouad <[email protected]>
…l AND wait for participants list

Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad DorraJaouad merged commit 4b72bf3 into stable30 Nov 13, 2024
46 checks passed
@DorraJaouad DorraJaouad deleted the backport/13329/stable30 branch November 13, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants