Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VideoBackgroundEditor): change the container of file picker #13313

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(VideoBackgroundEditor): change the container of file picker #13313

merged 1 commit into from
Sep 16, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🖤 Next Major (31) milestone Sep 16, 2024
@DorraJaouad DorraJaouad self-assigned this Sep 16, 2024
Antreesy
Antreesy approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy
Copy link
Contributor

/backport to stable30

@nickvergessen nickvergessen merged commit 5f9a1e2 into main Sep 16, 2024
46 checks passed
@nickvergessen nickvergessen deleted the fix/13312/background-editor branch September 16, 2024 09:14
@backportbot backportbot bot mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Video background file selector dialog dimensions broken
3 participants
@DorraJaouad @Antreesy @nickvergessen