Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Notification): Fix rich object parameters with non-string values #13200

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

provokateurin
Copy link
Member

Found using nextcloud/server#47662.
I temporarily pointed OCP to my local lib/public so psalm started finding the issues. In the future once the PR is merged it will be enforced by default.

πŸ› οΈ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed

@provokateurin provokateurin force-pushed the fix/notification/rich-object-parameters branch from 9e5cda2 to 14a7fdf Compare September 9, 2024 16:23
@nickvergessen nickvergessen added feature: api πŸ› οΈ OCS API for conversations, chats and participants feature: chat πŸ’¬ Chat and system messages labels Sep 9, 2024
@nickvergessen nickvergessen merged commit 816acd1 into main Sep 10, 2024
68 checks passed
@nickvergessen nickvergessen deleted the fix/notification/rich-object-parameters branch September 10, 2024 13:38
@nickvergessen
Copy link
Member

/backport to stable30

@nickvergessen
Copy link
Member

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api πŸ› οΈ OCS API for conversations, chats and participants feature: chat πŸ’¬ Chat and system messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants