Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(userStatus): migrate util to Typescript #13111

Merged
merged 3 commits into from
Sep 13, 2024
Merged

fix(userStatus): migrate util to Typescript #13111

merged 3 commits into from
Sep 13, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Aug 23, 2024
@Antreesy Antreesy self-assigned this Aug 23, 2024
ShGKme
ShGKme reviewed Aug 23, 2024
View reviewed changes
src/utils/userStatus.ts Outdated Show resolved Hide resolved
src/utils/userStatus.ts Outdated Show resolved Hide resolved
src/utils/userStatus.ts Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/12800/user-status-typescript branch 3 times, most recently from 9247b59 to 5d60eff Compare August 23, 2024 13:37
@Antreesy Antreesy force-pushed the fix/12800/user-status-typescript branch 2 times, most recently from 034057f to c7b33ee Compare August 25, 2024 08:42
@Antreesy Antreesy force-pushed the fix/12800/user-status-typescript branch from c7b33ee to d1a1075 Compare September 6, 2024 14:48
@Antreesy
Copy link
Contributor Author

Antreesy commented Sep 6, 2024

  • rebased
  • unify using of getPreloadedUserStatus
  • add types

@Antreesy
chore(ts): use exact path to types file
9c64b44 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix: move getPreloadedUserStatus to util
63008df 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix: migrate utils to TS
b11f5e9 
Signed-off-by: Antreesy <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/12800/user-status-typescript branch from d1a1075 to b11f5e9 Compare September 11, 2024 20:51
DorraJaouad
DorraJaouad approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 🦅

@Antreesy Antreesy merged commit 718d224 into main Sep 13, 2024
49 checks passed
@Antreesy Antreesy deleted the fix/12800/user-status-typescript branch September 13, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review backport-request feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @ShGKme @DorraJaouad