Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Quote): Don't trim the quote when it is not image share with caption #11166

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fix(Quote): Don't trim the quote when it is not image share with caption #11166

merged 1 commit into from
Dec 14, 2023

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Dec 8, 2023 •
edited by Antreesy
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Code review

🏁 Checklist

@DorraJaouad DorraJaouad added this to the 💞 Following Major (29) milestone Dec 8, 2023
@DorraJaouad DorraJaouad self-assigned this Dec 8, 2023
@DorraJaouad DorraJaouad added the feature: frontend 🖌️ "Web UI" client label Dec 8, 2023
@Antreesy

This comment was marked as resolved.

Sign in to view
Antreesy
Antreesy reviewed Dec 11, 2023
View reviewed changes
src/components/Quote.vue Outdated Show resolved Hide resolved
@Antreesy

This comment was marked as resolved.

Sign in to view
Antreesy
Antreesy reviewed Dec 14, 2023
View reviewed changes
src/components/Quote.vue Outdated Show resolved Hide resolved
Antreesy
Antreesy approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@DorraJaouad DorraJaouad merged commit 2363e94 into main Dec 14, 2023
36 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/quote-height branch December 14, 2023 15:30
@Antreesy
Copy link
Contributor

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@DorraJaouad @Antreesy