Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Pinia): migrate quoteReplyStore (Vuex) to chatExtrasStore (Pinia) #11165

Merged
merged 4 commits into from
Dec 13, 2023
Merged

feat(Pinia): migrate quoteReplyStore (Vuex) to chatExtrasStore (Pinia) #11165

merged 4 commits into from
Dec 13, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 8, 2023

☑️ Resolves

🖌️ UI Checklist

  • No visual changes

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Dec 8, 2023
@Antreesy Antreesy self-assigned this Dec 8, 2023
Antreesy
Antreesy commented Dec 8, 2023
View reviewed changes
src/stores/chatExtras.js Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/11053/migrate-quote-reply-store branch 2 times, most recently from c96d6a2 to 090110f Compare December 11, 2023 21:07
DorraJaouad
DorraJaouad reviewed Dec 12, 2023
View reviewed changes
src/stores/chatExtras.js Outdated Show resolved Hide resolved
src/store/conversationsStore.js Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/11053/migrate-quote-reply-store branch from 090110f to 869e44c Compare December 12, 2023 17:18
DorraJaouad
DorraJaouad approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing is blocking, all good 🦅.
But some tiny remarks

src/stores/chatExtras.js Show resolved Hide resolved
src/components/NewMessage/NewMessage.vue Show resolved Hide resolved
@Antreesy Antreesy merged commit 89df16b into main Dec 13, 2023
36 checks passed
@Antreesy Antreesy deleted the feat/11053/migrate-quote-reply-store branch December 13, 2023 08:16
@Antreesy
Copy link
Contributor Author

/backport to stable28

As it's tested fine on master, and may cause conflicts for further backports later on

@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
@Antreesy
Copy link
Contributor Author

/backport eb7c319 to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

follow-up(quoteReplyStore) - migrate to Pinia
2 participants
@Antreesy @DorraJaouad