Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shares): allow to retry failed uploads #11107

Merged
merged 4 commits into from
Dec 18, 2023
Merged

fix(shares): allow to retry failed uploads #11107

merged 4 commits into from
Dec 18, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 4, 2023 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

retry-upload.webm

Tip

Add if (Math.random() < 0.5) throw new Error() to performUpload function to fail some uploads

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added 2. developing bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Dec 4, 2023
@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Dec 4, 2023
@Antreesy Antreesy self-assigned this Dec 4, 2023
@Antreesy Antreesy force-pushed the fix/10768/retry-failed-uploads branch from d51cf38 to 5584fcc Compare December 15, 2023 11:50
@Antreesy Antreesy marked this pull request as ready for review December 15, 2023 11:51
@Antreesy
Copy link
Contributor Author

/backport to stable28

DorraJaouad
DorraJaouad approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 🦅

@DorraJaouad
Copy link
Contributor

Rebased

@DorraJaouad DorraJaouad merged commit c833bab into main Dec 18, 2023
36 checks passed
@DorraJaouad DorraJaouad deleted the fix/10768/retry-failed-uploads branch December 18, 2023 10:41
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Handle upload errors of files and allow to retry
2 participants
@Antreesy @DorraJaouad