Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Poll): Reorganize component structure and hide End Poll from first view #11099

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fix(Poll): Reorganize component structure and hide End Poll from first view #11099

merged 2 commits into from
Dec 4, 2023

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Dec 4, 2023 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image

🚧 Tasks

  • Design review
  • Code review

🏁 Checklist

@DorraJaouad DorraJaouad added this to the 💝 Next Patch (28) milestone Dec 4, 2023
@DorraJaouad DorraJaouad self-assigned this Dec 4, 2023
@Antreesy
Copy link
Contributor

Antreesy commented Dec 4, 2023

So, as you've started this, please check also inputs margin in NewMessagePollEditor:

image

Antreesy
Antreesy reviewed Dec 4, 2023
View reviewed changes
src/components/MessagesList/MessagesGroup/Message/MessagePart/Poll.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Poll.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Poll.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Poll.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Poll.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Poll.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Poll.vue Outdated Show resolved Hide resolved
Antreesy
Antreesy approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise OK, just some style nitpicks
Let's wait for design check on this

src/components/NewMessage/NewMessagePollEditor.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Poll.vue Outdated Show resolved Hide resolved
@nickvergessen
Copy link
Member

/backport to stable28

szaimen
szaimen approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshots LGTM :)

@DorraJaouad DorraJaouad merged commit 254f144 into main Dec 4, 2023
36 checks passed
@DorraJaouad DorraJaouad deleted the fix/10893/poll-buttons branch December 4, 2023 18:54
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@Antreesy Antreesy Antreesy approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
bug feature: frontend 🖌️ "Web UI" client feature: polls 📊
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Confusing prominent buttons on poll dialogue
4 participants
@DorraJaouad @Antreesy @nickvergessen @szaimen