Heal "In a call" user status

[nickvergessen]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

It's artificially possible to end up with a stuck "In a call" user status.

Steps to reproduce

diff --git a/lib/Status/Listener.php b/lib/Status/Listener.php
index a22cc8236..c40a020e1 100644
--- a/lib/Status/Listener.php
+++ b/lib/Status/Listener.php
@@ -80,6 +80,7 @@ class Listener implements IEventListener {
                        }
                }
 
+               sleep(5);
                $this->statusManager->setUserStatus(
                        $userId,
                        'call',

1. Apply patch to delay setting the actual user status to "In a call", but it could happen e.g. when the start of a call takes long due to federation or many push notifications, etc.
2. Start a call and quickly leave it again
3. Wait 5 seconds
4. Check your user status

Expected behaviour

Your user status returns to Online

Actual behaviour

Your user status is "In a call" for the rest of the time

Possible idea

When fetching the room list, check if there is a call in any of your rooms. If No and your user status is "In a call" (message_id=call, as the message text is translated) we should reset it. Sadly the message id is not part of the public API.