From c7e467bd4bbefd49169ca51a460c29528090027a Mon Sep 17 00:00:00 2001 From: Maksim Sukharev Date: Thu, 7 Dec 2023 11:39:09 +0100 Subject: [PATCH 1/3] chore(eslint): enable import/order rule again Signed-off-by: Maksim Sukharev --- .eslintrc.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index cdfeb5e8c60..9a921a5ee8d 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -15,7 +15,7 @@ module.exports = { 'import/newline-after-import': 'warn', 'import/no-named-as-default-member': 'off', 'import/order': [ - 'off', // TODO disabled with #10622 as it breaks tests and changes many components + 'warn', { groups: ['builtin', 'external', 'internal', ['parent', 'sibling', 'index'], 'unknown'], pathGroups: [ @@ -48,8 +48,8 @@ module.exports = { // group project components pattern: '*.vue', patternOptions: { matchBase: true }, - group: 'external', - position: 'after', + group: 'parent', + position: 'before', }, ], pathGroupsExcludedImportTypes: ['@nextcloud', 'vue-material-design-icons'], From 2d1080aa2f8ae5e9ddfd9893910c4c67a3c369d8 Mon Sep 17 00:00:00 2001 From: Maksim Sukharev Date: Thu, 7 Dec 2023 12:00:52 +0100 Subject: [PATCH 2/3] chore(eslint): run eslint Signed-off-by: Maksim Sukharev --- src/PublicShareAuthRequestPasswordButton.vue | 1 + src/components/AdminSettings/RecordingServers.vue | 3 ++- .../BreakoutRoomsParticipantsEditor.vue | 2 +- src/components/CallView/CallView.vue | 5 +++-- src/components/CallView/shared/LocalVideo.vue | 4 ++-- src/components/CallView/shared/Screen.vue | 2 +- src/components/CallView/shared/VideoVue.vue | 4 ++-- .../CallView/shared/ViewerOverlayCallView.vue | 4 ++-- .../RecordingConsentSettings.vue | 2 +- src/components/DialpadPanel.vue | 7 +++---- .../ConversationsList/Conversation.spec.js | 2 +- .../LeftSidebar/ConversationsList/Conversation.vue | 2 +- .../LeftSidebar/ConversationsListVirtual.vue | 2 +- src/components/LeftSidebar/LeftSidebar.vue | 12 ++++++------ .../NewGroupConversation/NewGroupConversation.vue | 6 +++--- .../SetContacts/SetContacts.vue | 2 +- src/components/MediaSettings/MediaSettings.vue | 2 +- .../MessagesGroup/Message/Message.spec.js | 2 +- .../MessagesList/MessagesGroup/Message/Message.vue | 4 ++-- .../MessagesGroup/Message/MessagePart/Poll.vue | 2 +- .../MessagesList/MessagesGroup/MessagesGroup.vue | 2 +- src/components/MessagesList/MessagesList.vue | 2 +- src/components/NewMessage/NewMessage.vue | 2 +- .../NewMessage/NewMessageUploadEditor.vue | 2 +- .../BreakoutRooms/BreakoutRoomsTab.vue | 3 +-- .../Participant/Participant.spec.js | 2 +- .../ParticipantsList/Participant/Participant.vue | 6 +++--- .../ParticipantPermissionsEditor.spec.js | 2 +- .../ParticipantsList/ParticipantsList.vue | 2 +- .../ParticipantsList/ParticipantsListVirtual.vue | 2 +- .../RightSidebar/Participants/ParticipantsTab.vue | 8 ++++---- src/components/RightSidebar/RightSidebar.vue | 4 ++-- .../SharedItems/SharedItemsBrowser.vue | 2 +- .../RightSidebar/SharedItems/SharedItemsTab.vue | 4 ++-- src/components/TopBar/CallButton.vue | 3 +-- src/components/TopBar/TopBar.vue | 4 ++-- src/composables/useActiveSession.js | 4 ++-- src/composables/useIsInCall.js | 2 +- src/composables/useSortParticipants.js | 2 +- src/main.js | 2 +- src/mainFilesSidebar.js | 2 +- src/mainPublicShareAuthSidebar.js | 2 +- src/mainPublicShareSidebar.js | 2 +- src/mainRecording.js | 3 +-- src/mixins/getParticipants.js | 2 +- src/services/callsService.js | 2 +- src/services/conversationsService.spec.js | 2 +- src/services/messagesService.spec.js | 2 +- src/store/actorStore.spec.js | 2 +- src/store/callViewStore.spec.js | 2 +- src/store/conversationsStore.spec.js | 2 +- src/store/fileUploadStore.spec.js | 2 +- src/store/messagesStore.spec.js | 4 ++-- src/store/participantsStore.spec.js | 4 ++-- src/stores/guestName.js | 3 ++- src/stores/settings.js | 2 +- src/utils/SignalingTypingHandler.spec.js | 2 +- .../JitsiStreamBackgroundEffect.js | 2 +- src/utils/media/pipeline/MediaDevicesSource.js | 2 +- .../media/pipeline/MediaDevicesSource.spec.js | 2 +- src/utils/media/pipeline/SpeakingMonitor.js | 2 +- src/utils/media/pipeline/TrackSinkSource.js | 2 +- src/utils/media/pipeline/TrackSource.js | 2 +- src/utils/media/pipeline/TrackToStream.js | 2 +- src/utils/media/pipeline/VirtualBackground.js | 2 +- src/utils/signaling.js | 2 +- src/utils/webrtc/analyzers/CallAnalyzer.js | 2 +- src/utils/webrtc/analyzers/ParticipantAnalyzer.js | 2 +- .../webrtc/analyzers/PeerConnectionAnalyzer.js | 2 +- src/utils/webrtc/index.js | 14 +++++++------- .../webrtc/models/CallParticipantCollection.js | 2 +- .../webrtc/models/LocalCallParticipantModel.js | 2 +- src/utils/webrtc/simplewebrtc/localmedia.js | 2 +- src/utils/webrtc/simplewebrtc/peer.js | 1 + src/utils/webrtc/webrtc.js | 2 +- src/views/NotFoundView.vue | 3 ++- src/views/SessionConflictView.vue | 3 ++- src/views/WelcomeView.vue | 2 ++ 78 files changed, 115 insertions(+), 110 deletions(-) diff --git a/src/PublicShareAuthRequestPasswordButton.vue b/src/PublicShareAuthRequestPasswordButton.vue index abf278b3c2b..53e0004e95d 100644 --- a/src/PublicShareAuthRequestPasswordButton.vue +++ b/src/PublicShareAuthRequestPasswordButton.vue @@ -40,6 +40,7 @@