From 60cb14e0b69fbd340b03b47da01027239df2c0a3 Mon Sep 17 00:00:00 2001
From: Maksim Sukharev <antreesy.web@gmail.com>
Date: Sat, 14 Sep 2024 15:04:09 +0200
Subject: [PATCH] fix: move page visibility check to composable

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
---
 src/App.vue                                  | 44 +++++++++-----------
 src/components/MessagesList/MessagesList.vue | 15 +++----
 src/components/TopBar/CallTime.vue           |  9 +++-
 src/composables/useActiveSession.js          |  5 ++-
 src/composables/useGetParticipants.js        |  4 +-
 src/composables/useWindowVisibility.ts       | 36 ++++++++++++++++
 src/store/windowVisibilityStore.js           | 24 -----------
 7 files changed, 78 insertions(+), 59 deletions(-)
 create mode 100644 src/composables/useWindowVisibility.ts

diff --git a/src/App.vue b/src/App.vue
index 858f33a1a6a..2f010d83d69 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -41,6 +41,7 @@ import { useActiveSession } from './composables/useActiveSession.js'
 import { useHashCheck } from './composables/useHashCheck.js'
 import { useIsInCall } from './composables/useIsInCall.js'
 import { useSessionIssueHandler } from './composables/useSessionIssueHandler.js'
+import { useWindowVisibility } from './composables/useWindowVisibility.ts'
 import { CONVERSATION, PARTICIPANT } from './constants.js'
 import Router from './router/router.js'
 import BrowserStorage from './services/BrowserStorage.js'
@@ -71,6 +72,7 @@ export default {
 			isLeavingAfterSessionIssue: useSessionIssueHandler(),
 			isMobile: useIsMobile(),
 			isNextcloudTalkHashDirty: useHashCheck(),
+			isWindowVisible: useWindowVisibility(),
 			supportSessionState: useActiveSession(),
 			federationStore: useFederationStore(),
 		}
@@ -88,9 +90,6 @@ export default {
 	},
 
 	computed: {
-		windowIsVisible() {
-			return this.$store.getters.windowIsVisible()
-		},
 		isFullscreen() {
 			return this.$store.getters.isFullscreen()
 		},
@@ -189,7 +188,7 @@ export default {
 
 	watch: {
 		atLeastOneLastMessageIdChanged() {
-			if (this.windowIsVisible) {
+			if (this.isWindowVisible) {
 				return
 			}
 
@@ -220,7 +219,23 @@ export default {
 					toggle?.removeAttribute('data-theme-dark')
 				}
 			}
-		}
+		},
+
+		isWindowVisible(value) {
+			if (value) {
+				// Remove the potential "*" marker for unread chat messages
+				let title = this.getConversationName(this.token)
+				if (window.document.title.indexOf(t('spreed', 'Duplicate session')) === 0) {
+					title = t('spreed', 'Duplicate session')
+				}
+				this.setPageTitle(title, false)
+			} else {
+				// Copy the last message map to the saved version,
+				// this will be our reference to check if any chat got a new
+				// message since the last visit
+				this.savedLastMessageMap = this.lastMessageMap
+			}
+		},
 	},
 
 	beforeCreate() {
@@ -249,7 +264,6 @@ export default {
 		if (!getCurrentUser()) {
 			EventBus.off('should-refresh-conversations', this.debounceRefreshCurrentConversation)
 		}
-		document.removeEventListener('visibilitychange', this.changeWindowVisibility)
 
 		unsubscribe('notifications:action:execute', this.interceptNotificationActions)
 
@@ -272,7 +286,6 @@ export default {
 		}
 
 		window.addEventListener('resize', this.onResize)
-		document.addEventListener('visibilitychange', this.changeWindowVisibility)
 
 		this.onResize()
 
@@ -625,23 +638,6 @@ export default {
 			this.fetchSingleConversation(this.token)
 		},
 
-		changeWindowVisibility() {
-			this.$store.dispatch('setWindowVisibility', !document.hidden)
-			if (this.windowIsVisible) {
-				// Remove the potential "*" marker for unread chat messages
-				let title = this.getConversationName(this.token)
-				if (window.document.title.indexOf(t('spreed', 'Duplicate session')) === 0) {
-					title = t('spreed', 'Duplicate session')
-				}
-				this.setPageTitle(title, false)
-			} else {
-				// Copy the last message map to the saved version,
-				// this will be our reference to check if any chat got a new
-				// message since the last visit
-				this.savedLastMessageMap = this.lastMessageMap
-			}
-		},
-
 		/**
 		 * Set the page title to the conversation name
 		 *
diff --git a/src/components/MessagesList/MessagesList.vue b/src/components/MessagesList/MessagesList.vue
index 09237eab2b6..00388517223 100644
--- a/src/components/MessagesList/MessagesList.vue
+++ b/src/components/MessagesList/MessagesList.vue
@@ -59,6 +59,7 @@
 <script>
 import debounce from 'debounce'
 import uniqueId from 'lodash/uniqueId.js'
+import { computed } from 'vue'
 
 import Message from 'vue-material-design-icons/Message.vue'
 
@@ -76,6 +77,7 @@ import LoadingPlaceholder from '../UIShared/LoadingPlaceholder.vue'
 import TransitionWrapper from '../UIShared/TransitionWrapper.vue'
 
 import { useIsInCall } from '../../composables/useIsInCall.js'
+import { useWindowVisibility } from '../../composables/useWindowVisibility.ts'
 import { ATTENDEE, CHAT, CONVERSATION } from '../../constants.js'
 import { EventBus } from '../../services/EventBus.js'
 import { useChatExtrasStore } from '../../stores/chatExtras.js'
@@ -121,10 +123,13 @@ export default {
 
 	emits: ['update:is-chat-scrolled-to-bottom'],
 
-	setup() {
+	setup(props) {
+		const isWindowVisible = useWindowVisibility()
+		const isChatVisible = computed(() => isWindowVisible.value && props.isVisible)
 		return {
 			isInCall: useIsInCall(),
 			chatExtrasStore: useChatExtrasStore(),
+			isChatVisible,
 		}
 	},
 
@@ -177,10 +182,6 @@ export default {
 	},
 
 	computed: {
-		isWindowVisible() {
-			return this.$store.getters.windowIsVisible() && this.isVisible
-		},
-
 		visualLastReadMessageId() {
 			return this.$store.getters.getVisualLastReadMessageId(this.token)
 		},
@@ -262,7 +263,7 @@ export default {
 	},
 
 	watch: {
-		isWindowVisible(visible) {
+		isChatVisible(visible) {
 			if (visible) {
 				this.onWindowFocus()
 			}
@@ -1107,7 +1108,7 @@ export default {
 				} else if (!this.isSticky) {
 					// Reading old messages
 					return
-				} else if (!this.isWindowVisible) {
+				} else if (!this.isChatVisible) {
 					const firstUnreadMessageHeight = this.$refs.scroller.scrollHeight - this.$refs.scroller.scrollTop - this.$refs.scroller.offsetHeight
 					const scrollBy = firstUnreadMessageHeight < 40 ? 10 : 40
 					// We jump half a message and stop autoscrolling, so the user can read up
diff --git a/src/components/TopBar/CallTime.vue b/src/components/TopBar/CallTime.vue
index f1a098bdc59..d17e431f4eb 100644
--- a/src/components/TopBar/CallTime.vue
+++ b/src/components/TopBar/CallTime.vue
@@ -67,6 +67,7 @@ import NcButton from '@nextcloud/vue/dist/Components/NcButton.js'
 import NcLoadingIcon from '@nextcloud/vue/dist/Components/NcLoadingIcon.js'
 import NcPopover from '@nextcloud/vue/dist/Components/NcPopover.js'
 
+import { useWindowVisibility } from '../../composables/useWindowVisibility.ts'
 import { CALL } from '../../constants.js'
 import { formattedTime } from '../../utils/formattedTime.ts'
 
@@ -93,6 +94,12 @@ export default {
 		},
 	},
 
+	setup() {
+		return {
+			isWindowVisible: useWindowVisibility(),
+		}
+	},
+
 	data() {
 		return {
 			callTime: undefined,
@@ -198,7 +205,7 @@ export default {
 			this.isCallDurationHintShown = true
 
 			// close the popover after 10 seconds
-			if (this.$store.getters.windowIsVisible()) {
+			if (this.isWindowVisible) {
 				setTimeout(() => {
 					this.showPopover = false
 				}, 10000)
diff --git a/src/composables/useActiveSession.js b/src/composables/useActiveSession.js
index 5135ecb0ca1..32c3ee55408 100644
--- a/src/composables/useActiveSession.js
+++ b/src/composables/useActiveSession.js
@@ -7,6 +7,7 @@ import { computed, onBeforeMount, onBeforeUnmount, ref, watch } from 'vue'
 
 import { useIsInCall } from './useIsInCall.js'
 import { useStore } from './useStore.js'
+import { useWindowVisibility } from './useWindowVisibility.ts'
 import { SESSION } from '../constants.js'
 import { hasTalkFeature } from '../services/CapabilitiesManager.ts'
 import { setSessionState } from '../services/participantsService.js'
@@ -31,7 +32,7 @@ export function useActiveSession() {
 	}
 
 	const isInCall = useIsInCall()
-	const windowIsVisible = computed(() => store.getters.windowIsVisible())
+	const isWindowVisible = useWindowVisibility()
 
 	const inactiveTimer = ref(null)
 	const currentState = ref(SESSION.STATE.ACTIVE)
@@ -41,7 +42,7 @@ export function useActiveSession() {
 		currentState.value = SESSION.STATE.ACTIVE
 	})
 
-	watch(windowIsVisible, (value) => {
+	watch(isWindowVisible, (value) => {
 		// Change state if tab is hidden or minimized
 		if (value) {
 			setSessionAsActive()
diff --git a/src/composables/useGetParticipants.js b/src/composables/useGetParticipants.js
index 8e1b6cb5e1b..6e2e7d117fe 100644
--- a/src/composables/useGetParticipants.js
+++ b/src/composables/useGetParticipants.js
@@ -9,6 +9,7 @@ import { subscribe, unsubscribe } from '@nextcloud/event-bus'
 
 import { useIsInCall } from './useIsInCall.js'
 import { useStore } from './useStore.js'
+import { useWindowVisibility } from './useWindowVisibility.ts'
 import { CONVERSATION } from '../constants.js'
 import { EventBus } from '../services/EventBus.js'
 
@@ -23,6 +24,7 @@ export function useGetParticipants(isActive = ref(true), isTopBar = true) {
 	const token = computed(() => store.getters.getToken())
 	const conversation = computed(() => store.getters.conversation(token.value))
 	const isInCall = useIsInCall()
+	const isWindowVisible = useWindowVisibility()
 	const isOneToOneConversation = computed(() => conversation.value?.type === CONVERSATION.TYPE.ONE_TO_ONE
 		|| conversation.value?.type === CONVERSATION.TYPE.ONE_TO_ONE_FORMER)
 	let fetchingParticipants = false
@@ -67,7 +69,7 @@ export function useGetParticipants(isActive = ref(true), isTopBar = true) {
 			return
 		}
 
-		if (store.getters.windowIsVisible() && (isInCall.value || !conversation.value?.hasCall)) {
+		if (isWindowVisible.value && (isInCall.value || !conversation.value?.hasCall)) {
 			debounceFastUpdateParticipants()
 		} else {
 			debounceSlowUpdateParticipants()
diff --git a/src/composables/useWindowVisibility.ts b/src/composables/useWindowVisibility.ts
new file mode 100644
index 00000000000..8c2c656ac3d
--- /dev/null
+++ b/src/composables/useWindowVisibility.ts
@@ -0,0 +1,36 @@
+/*
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import { createSharedComposable } from '@vueuse/core'
+import { readonly, ref, onBeforeMount, onBeforeUnmount } from 'vue'
+import type { Ref, DeepReadonly } from 'vue'
+
+/**
+ * Composable to check whether the page is visible.
+ * @return {DeepReadonly<Ref<boolean>>} - computed boolean whether the page is visible
+ */
+function useWindowVisibilityComposable() {
+	const isWindowVisible = ref<boolean>(!document.hidden)
+
+	const changeWindowVisibility = () => {
+		isWindowVisible.value = !document.hidden
+	}
+
+	onBeforeMount(() => {
+		document.addEventListener('visibilitychange', changeWindowVisibility)
+	})
+
+	onBeforeUnmount(() => {
+		document.removeEventListener('visibilitychange', changeWindowVisibility)
+	})
+
+	return readonly(isWindowVisible)
+}
+
+/**
+ * Shared composable to check whether the page is visible.
+ * @return {DeepReadonly<Ref<boolean>>} - computed boolean whether the page is visible
+ */
+export const useWindowVisibility = createSharedComposable(useWindowVisibilityComposable)
diff --git a/src/store/windowVisibilityStore.js b/src/store/windowVisibilityStore.js
index 2638b44e34b..f8af1239da5 100644
--- a/src/store/windowVisibilityStore.js
+++ b/src/store/windowVisibilityStore.js
@@ -4,30 +4,16 @@
  */
 
 const state = {
-	visible: true,
 	fullscreen: false,
 }
 
 const getters = {
-	windowIsVisible: (state) => () => {
-		return state.visible
-	},
 	isFullscreen: (state) => () => {
 		return state.fullscreen
 	},
 }
 
 const mutations = {
-	/**
-	 * Sets the current visibility state
-	 *
-	 * @param {object} state current store state;
-	 * @param {boolean} value the value;
-	 */
-	setVisibility(state, value) {
-		state.visible = value
-	},
-
 	/**
 	 * Sets the fullscreen state
 	 *
@@ -40,16 +26,6 @@ const mutations = {
 }
 
 const actions = {
-	/**
-	 * Sets the current visibility state
-	 *
-	 * @param {object} context the context object;
-	 * @param {boolean} value the value;
-	 */
-	setWindowVisibility(context, value) {
-		context.commit('setVisibility', value)
-	},
-
 	/**
 	 * Sets the fullscreen state
 	 *