fix(settings): Provide visual feedback 4 encryption toggle #49200
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
fix/48829/visual-feedback-4-encryption-toggle
branch
from
35222b8
to
2a2f629
Compare
nfebe
added
enhancement
3. to review
`Object.entries([])` would return an empty array, that leads to the `find` return undefined. `encryptionReady` and `encryptionEnabled` also returns undefined when no encryption module is available or functional (I guess). Signed-off-by: nfebe <[email protected]>
Show visual feedback if user clicks on encryption toggle when it cannot be activated. Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/48829/visual-feedback-4-encryption-toggle
branch
from
2731f3d
to
016738f
Compare
skjnldsv
reviewed
Nov 11, 2024
That is one option, I am just did this around the feedback from a user.... cc: @marcoambrosini @jancborchardt Plus that has the limitation that we have to display the warning at all times somewhere on the page as disabled components do not respond to events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show visual feedback if user clicks on encryption toggle when it cannot be activated.
Demo
feedback-no-encryption-module.webm
Other improvement
Object.entries([])would return an empty array, that leads to thefindencryptionReadyandencryptionEnabledalso returns undefined when no encryption module is available or functional (I guess).Resolves : #48829