Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): offer clipboard fallback for non-secure environments #49141

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat(core): offer clipboard fallback for non-secure environments #49141

merged 2 commits into from
Nov 8, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 8, 2024

Fix #40666

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 8, 2024
@skjnldsv skjnldsv requested review from susnux, juliusknorr and a team November 8, 2024 07:45
@skjnldsv skjnldsv self-assigned this Nov 8, 2024
@skjnldsv skjnldsv requested review from Pytal and sorbaugh and removed request for a team November 8, 2024 07:45
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 8, 2024

Could easily be backported

@skjnldsv skjnldsv mentioned this pull request Nov 8, 2024
Closed
8 tasks
st3iny
st3iny approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works on Chromium and Firefox.

Is a bit hacky but as long as it works, I'm fine.

susnux
susnux approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it works, fine with both.

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 8, 2024

Is a bit hacky but as long as it works, I'm fine.

I agree, we use a deprecated method, but this is an edge case anyway 🤷

@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv
chore: compile assets
a758707 
Signed-off-by: skjnldsv <[email protected]>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 8, 2024
@skjnldsv skjnldsv merged commit deb28f5 into master Nov 8, 2024
118 checks passed
@skjnldsv skjnldsv deleted the feat/clipboard-fallback branch November 8, 2024 13:28
@joshtrichards joshtrichards mentioned this pull request Nov 8, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@st3iny st3iny st3iny approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement technical debt
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Bug]: No clipboard access for non-https NextCloud servers
3 participants
@skjnldsv @st3iny @susnux