Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files_sharing): allow not deleting expiring shares #48225

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 19, 2024

Fix #17996

Feature

Shares that expires are just deleted. Which leads to confusion.

  • We don't even know if the share existed or not....
  • With the new file request, we might want to extend the drop period time...
  • We need more transparency

Solution

  • Allow admins to disable share deletion on expiration (opt-in)
    2024-09-19_19-27
  • Adds a new view to list all expired shares
    image

Status

  • Add admin setting
  • Add api controller
  • Add new view
  • Add integration tests

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Sep 19, 2024
@skjnldsv skjnldsv self-assigned this Sep 19, 2024
@skjnldsv skjnldsv force-pushed the feat/disable-share-deletion branch 3 times, most recently from 099984d to 98e0fe3 Compare September 20, 2024 10:52
apps/settings/lib/Settings/Admin/Sharing.php Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep list of expired public shares
1 participant