chore: Remove deprecated IJob::execute method
#48197
Draft
+12
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
commented
Sep 18, 2024
| * | ||
| * To implement a background job, you must extend either \OCP\BackgroundJob\Job, | ||
| * \OCP\BackgroundJob\TimedJob or \OCP\BackgroundJob\QueuedJob | ||
| * | ||
| * @since 7.0.0 | ||
| * @since 25.0.0 deprecated `execute()` method in favor of `start()` | ||
| * @since 31.0.0 removed deprecated `execute()` method |
There was a problem hiding this comment.
Suggested change
| * @since 31.0.0 removed deprecated `execute()` method | |
| * @since 33.0.0 removed deprecated `execute()` method |
susnux
commented
Sep 18, 2024
| /** | ||
| * Simple base class for a one time background job | ||
| * | ||
| * @since 15.0.0 | ||
| * @since 25.0.0 deprecated `execute()` method in favor of `start()` | ||
| * @since 31.0.0 removed deprecated `execute()` method |
There was a problem hiding this comment.
Suggested change
| * @since 31.0.0 removed deprecated `execute()` method | |
| * @since 33.0.0 removed deprecated `execute()` method |
susnux
commented
Sep 18, 2024
| /** | ||
| * Simple base class to extend to run periodic background jobs. | ||
| * Call setInterval with your desired interval in seconds from the constructor. | ||
| * | ||
| * @since 15.0.0 | ||
| * @since 25.0.0 deprecated `execute()` method in favor of `start()` | ||
| * @since 31.0.0 removed deprecated `execute()` method |
There was a problem hiding this comment.
Suggested change
| * @since 31.0.0 removed deprecated `execute()` method | |
| * @since 33.0.0 removed deprecated `execute()` method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IJob::executeis deprecated for quite some time andILoggerdoes not provide any logging functions anymore.Now after 3 years we can remove it with Nextcloud 33.
Checklist