chore: Add parameter type hints to parameters #48195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested review from
ChristophWurst,
miaulalala and
st3iny
as code owners
| @@ -26,5 +26,5 @@ interface IProvider { | |||
| * when they did not handle the event. Throwing \InvalidArgumentException directly is deprecated and will | |||
| * be logged as an error in Nextcloud 39. | |||
| */ | |||
| public function parse($language, IEvent $event, ?IEvent $previousEvent = null); | |||
| public function parse(string $language, IEvent $event, ?IEvent $previousEvent = null); | |||
There was a problem hiding this comment.
Possibly implemented by apps
There was a problem hiding this comment.
but its an interface, so it can be stronger than an implementation
| * @since 7.0.0 | ||
| */ | ||
| public function __construct($msg) { | ||
| public function __construct(string $msg) { |
There was a problem hiding this comment.
Possibly extended by an app
There was a problem hiding this comment.
Same for AppFramework/ApiController.php and many more …
I thought it's only for the parameters, but yeah when it's not an interface but a class, we need to do it the other way around
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
techdebt/noid/add-parameter-typehints
branch
from
fe23079
to
e271318
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist