Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move to ZipFolderPlugin for downloading multiple-nodes #48098

Merged
merged 6 commits into from
Sep 28, 2024
Merged

feat: Move to ZipFolderPlugin for downloading multiple-nodes #48098

merged 6 commits into from
Sep 28, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 16, 2024 •
edited by skjnldsv
Loading

Fix #41037

Summary

This contains multiple "things":

  • ❇️ Allow GET on folders to download them
    • if no accept header for ZIP is sent then (for browser download) allow GET params but if nothing set then fallback to Sabre -> should be non-breaking
  • 🐛 This now also allows downloading "select-multiple" files form e.g. "recent" or "favorites" view where the files are not really located in the same folder.

Checklist

@susnux susnux added the 3. to review Waiting for reviews label Sep 16, 2024
@susnux susnux requested a review from come-nc September 16, 2024 14:44
@susnux susnux added this to the Nextcloud 31 milestone Sep 16, 2024
@susnux susnux marked this pull request as ready for review September 16, 2024 15:35
@susnux susnux force-pushed the feat/zip-folder-plugin branch 2 times, most recently from 197f151 to 6c97ecf Compare September 16, 2024 23:56
@skjnldsv skjnldsv mentioned this pull request Sep 17, 2024
Closed
@susnux susnux force-pushed the feat/zip-folder-plugin branch 4 times, most recently from 62a1afa to 7a29e55 Compare September 26, 2024 23:28
@susnux
feat(files): Make the files download action use WebDAV zip download
0f6760c 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
feat(files_sharing): Make ShareController download route use the DA…
e9d5906 
…V `ZipFolderPlugin`

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
chore: Drop unused legacy OC_Files
eb69e89 
It is replaced with the Sabre `ZipFolderPlugin` and apps should use the `OCP\AppFramework\Http\StreamResponse`.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
chore: compile assets
ca8d576 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux merged commit 31ad1c5 into master Sep 28, 2024
173 checks passed
@susnux susnux deleted the feat/zip-folder-plugin branch September 28, 2024 12:24
@susnux susnux mentioned this pull request Sep 28, 2024
Merged
This was referenced Sep 28, 2024
Merged
Merged
@provokateurin provokateurin mentioned this pull request Sep 30, 2024
Merged
4 tasks
@joshtrichards joshtrichards mentioned this pull request Nov 9, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@provokateurin provokateurin Awaiting requested review from provokateurin

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug enhancement feature: files
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

Honor Accept header when downloading directories
3 participants
@susnux @skjnldsv @come-nc