-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DB): set sharding parameters only when intended #47611
Conversation
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
More complicated, as |
ah, partly because the configkey is misspelled there… Someone should invent constants 🤪 UPDATE: PEBCAK 🤪 |
@juliushaertl if you could throw another eyeball on the new commit 🙇 |
Second commit also looks good to me 👍 @blizzz |
Signed-off-by: Arthur Schiwon <[email protected]>
0005ec0
to
edaa4d1
Compare
Signed-off-by: Arthur Schiwon <[email protected]>
Also looks good 👍 |
Summary
32bit setup fails to due to AutoIncrementHandler
Checklist