-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): checkbox field type #47290
Conversation
d9995e1
to
494bf61
Compare
e226009
to
cff52d9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cff52d9
to
8a7e847
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally fine, just some small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice design-wise! :)
16f9565
to
c0c6e6a
Compare
/backport to stable30 |
@@ -29,11 +26,12 @@ | |||
</NcModal> | |||
</template> | |||
|
|||
<script lang="ts"> | |||
<script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why reverting to JS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't using TypeScript in this file, but if it makes it more consistent with the rest of the files I can leave it as TS.
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
9ba3f16
to
a82a542
Compare
Summary
This PR will introduce a checkbox type when filling templates.
Part of nextcloud/richdocuments#3917
2024-08-26.13-01-49.mp4
Note
Tests are implemented from the richdocuments side: nextcloud/richdocuments#3919
Checklist