Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: template folder and file request menu order #46913

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix: template folder and file request menu order #46913

merged 2 commits into from
Jul 31, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 31, 2024 •
edited
Loading

image

And refactor dialog usage

@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Jul 31, 2024
@skjnldsv skjnldsv requested review from susnux and a team July 31, 2024 12:35
@skjnldsv skjnldsv self-assigned this Jul 31, 2024
@skjnldsv skjnldsv requested review from nfebe and Pytal and removed request for a team July 31, 2024 12:35
@skjnldsv skjnldsv changed the title chore(files_sharing): use spawnDialog for new file request handler fix template folder and file request menu order Jul 31, 2024
@skjnldsv skjnldsv changed the title fix template folder and file request menu order fix: template folder and file request menu order Jul 31, 2024
nfebe
nfebe approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

susnux
susnux approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv
Copy link
Member Author

/compile rebase-amend /dist

@susnux susnux merged commit c8c84e6 into master Jul 31, 2024
111 checks passed
@susnux susnux deleted the fix/menu-order branch July 31, 2024 19:52
@blizzz blizzz mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfebe nfebe nfebe approved these changes

@susnux susnux susnux approved these changes

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: files feature: sharing technical debt
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @susnux @nfebe