Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(files_versions): Move to OCP #46756

Closed
wants to merge 4 commits into from
Closed

chore(files_versions): Move to OCP #46756

wants to merge 4 commits into from

Conversation

solracsf
Copy link
Member

Checklist

@solracsf solracsf added the 2. developing Work in progress label Jul 25, 2024
if (!$users_view->file_exists($version)) {
$users_view->copy('files'.$filename, 'files_versions'.$filename.'.v'.$users_view->filemtime('files'.$filename));
$users_view->copy('files' . $filename, 'files_versions' . $filename . '.v' . $users_view->filemtime('files' . $filename));

Check notice

Code scanning / Psalm

RiskyTruthyFalsyComparison Note

Operand of type bool|mixed contains type mixed, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.
apps/files_versions/lib/Db/VersionsMapper.php Fixed Show fixed Hide fixed
apps/files_versions/lib/Expiration.php Fixed Show fixed Hide fixed
apps/files_versions/lib/Expiration.php Fixed Show fixed Hide fixed
apps/files_versions/lib/Expiration.php Fixed Show fixed Hide fixed
@solracsf solracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 25, 2024
@solracsf solracsf added this to the Nextcloud 30 milestone Jul 25, 2024
@solracsf solracsf enabled auto-merge July 25, 2024 19:32
@solracsf solracsf disabled auto-merge July 25, 2024 20:03
@solracsf
Copy link
Member Author

Any idea why Cypress is faling here? 🤔

@susnux susnux added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Jul 25, 2024
Signed-off-by: Git'Fellow <[email protected]>
@solracsf solracsf closed this Jul 27, 2024
@solracsf solracsf deleted the versMoveToOCP branch July 27, 2024 09:34
@solracsf solracsf removed this from the Nextcloud 30 milestone Jul 27, 2024
@solracsf solracsf removed 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jul 27, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants