[stable28] fix: Pass the mountpoint target user to storages without owner #46680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
force-pushed
the
backport/44294/stable28
branch
from
8b31c0e
to
53d6d60
Compare
skjnldsv
added
2. developing
juliusknorr
force-pushed
the
backport/44294/stable28
branch
from
53d6d60
to
74fd470
Compare
juliusknorr
approved these changes
Aug 6, 2024
solracsf
added
3. to review
Storages that do not have a dedicated owner (e.g. groupfolders, external storages) currently always assume the current session user as the owner. This leads to several issues when there is no user session but a node is obtained through a user folder. In order to have the correct user available we need to pass the user that is used to setup a mountpoint along to the storage layer as we generally assume that an owner is available for those. Signed-off-by: Julius Härtl <[email protected]>
AndyScherzinger
force-pushed
the
backport/44294/stable28
branch
from
74fd470
to
53f92e6
Compare
come-nc
requested changes
Sep 3, 2024
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Andy Scherzinger <[email protected]>
come-nc
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #44294
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.