Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] fix(dav): Make createCalendarObject atomic #45472

Merged
merged 1 commit into from
May 29, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 22, 2024

Summary

Partial backport of #36528

Checklist

Partial backport of #36528

Signed-off-by: Ferdinand Thiessen <[email protected]>
$this->dispatcher->dispatchTyped(new CalendarObjectCreatedEvent($calendarId, $calendarRow, $shares, $objectRow));
} else {
$subscriptionRow = $this->getSubscriptionById($calendarId);
$this->dispatcher->dispatchTyped(new CalendarObjectCreatedEvent($calendarId, $calendarRow, $shares, $objectRow));

Check notice

Code scanning / Psalm

PossiblyNullArgument Note

Argument 2 of OCA\DAV\Events\CalendarObjectCreatedEvent::__construct cannot be null, possibly null value provided
@szaimen szaimen changed the title fix(dav): Make createCalendarObject atomic [stable26] fix(dav): Make createCalendarObject atomic May 23, 2024
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susnux
Copy link
Contributor Author

susnux commented May 29, 2024

Drone unrelated, can you merge @Altahrim ?

@Altahrim Altahrim removed the 2. developing Work in progress label May 29, 2024
@Altahrim Altahrim merged commit 7840b4a into stable26 May 29, 2024
36 of 38 checks passed
@Altahrim Altahrim deleted the fix/26-caldav-atomic branch May 29, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants