Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RichObjectStrings): Add missing Talk 'file' metadata fields #45424

Merged

Conversation

provokateurin
Copy link
Member

Summary

Clients should be able to rely on these fields, thus they should be documented in the definitions. These fields were added in nextcloud/spreed#7776 and nextcloud/spreed#11093.

I don't think backporting these changes is useful as this is only for documentation and validation purposes and doesn't fix any bug. For now I've set the since to the Server versions for the corresponding Talk releases, but it might make sense to set them only to 30.0.0 to avoid any confusion and instability.

Checklist

@provokateurin provokateurin merged commit edd59ee into master Jun 6, 2024
155 checks passed
@provokateurin provokateurin deleted the feat/richobjectstrings/missing-talk-file-metadata branch June 6, 2024 10:40
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants