Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow to enforce windows compatibility #45220

Closed
wants to merge 7 commits into from
Closed

feat: Allow to enforce windows compatibility #45220

wants to merge 7 commits into from

Commits on May 7, 2024

  1. feat: Add getForbiddenFilenames to OCP\Util and ensure forbidden … 

    …files are enforced

* Provide filename blacklist in public `\OCP\Util`
* Use filename blacklist and forbidden characters also in `Filesystem::isFileBlacklisted`
* Drop unused and deprecated `\OC_Util::isValidFileName`

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed May 7, 2024
    Configuration menu
    Copy the full SHA
    242b04e View commit details
    Browse the repository at this point in the history

  2. feat: Cache filename blacklist and forbidden filename characters 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5593259 View commit details
    Browse the repository at this point in the history

  3. fix: Move filename validation to one common place 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8b85774 View commit details
    Browse the repository at this point in the history

  4. fix: Deprecate \OCP\Files\FileInfo::BLACKLIST_FILES_REGEX as this i… 

    …s unused

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3f0657f View commit details
    Browse the repository at this point in the history

  5. fix(JSConfig): Add forbidden_filenames and `forbidden_filename_char… 

    …acters` to the `oc_config`

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed May 7, 2024
    Configuration menu
    Copy the full SHA
    cc77c89 View commit details
    Browse the repository at this point in the history

  6. fix: Make forbidden filename list case insensitive again 

    It previously was, even if not documented, case insensitive.

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed May 7, 2024
    Configuration menu
    Copy the full SHA
    60838bf View commit details
    Browse the repository at this point in the history

  7. feat: Allow to enforce Windows compatible file and folder names 

    This will:
* Deny characters forbidden on Windows
* Deny files with names which are reserved on Windows
* Deny trailing dot or space
* Deny files or folders which are not case-insensitive unique in a folder

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed May 7, 2024
    Configuration menu
    Copy the full SHA
    30a981b View commit details
    Browse the repository at this point in the history