fix(files_sharing): fix sharing tab translations #41301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable27 |
artonge
approved these changes
Nov 6, 2023
susnux
approved these changes
Nov 6, 2023
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/files_sharing--translations
branch
from
0e3d1f9
to
eb9257b
Compare
|
Rebased onto master and resolved conflicts |
Merged
|
drone is unrelated |
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seems to be a regression of #39472
The generated permissions list doesn't work as a translation key in runtime. Also, the translation key is case-sensitive.
Screenshots
TODO
toLocaleLowerCaseto change the case instead of[0].toUpperCaseChecklist