Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove @nextcloud/vue-dashboard #40748

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 2, 2023

Summary

@nextcloud/vue-dashboard is deprecated and actually not used in server anymore.
But it has some dependencies, including a very old @nextcloud/vue@3.

Removed 🧹

No dist changes after build.

TODO

  • Uninstall @nextcloud/vue-dashboard
  • Remove the only @nextcloud/vue-dashboard mention - in the webpack config

Checklist

@ShGKme ShGKme added 3. to review Waiting for reviews technical debt labels Oct 2, 2023
@ShGKme ShGKme self-assigned this Oct 2, 2023
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 2, 2023

Drone error unrelated

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation makes sense but didnt test

@skjnldsv skjnldsv merged commit bdf1bfb into master Oct 3, 2023
38 of 39 checks passed
@skjnldsv skjnldsv deleted the chore/remove-nextcloud-vue-dashboard branch October 3, 2023 08:23
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 3, 2023
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 28 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants