Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(settings): Semantic user table markup #40719

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 30, 2023

Summary

  • Add in-house table-friendly virtual list
  • Always keep user actions stickied to the right when toggling columns
  • Adjust tests

No visual changes

Checklist

@Pytal Pytal added the 2. developing Work in progress label Sep 30, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Sep 30, 2023
@Pytal Pytal self-assigned this Sep 30, 2023
@Pytal Pytal force-pushed the enh/a11y/semantic-user-table branch 2 times, most recently from 4f5ef26 to 53350bf Compare October 5, 2023 00:37
@Pytal Pytal changed the title Semantic user table enh(settings): Semantic user table markup Oct 5, 2023
@Pytal Pytal force-pushed the enh/a11y/semantic-user-table branch from 53350bf to c293ed6 Compare October 5, 2023 00:54
@Pytal Pytal marked this pull request as ready for review October 5, 2023 00:56
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the performances still good? Bart and I got caught with some limitations when we implemented our own, like img flickering and white spaces when scrolling fast.

Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge task 🤪

@Pytal Pytal force-pushed the enh/a11y/semantic-user-table branch from c293ed6 to 091b3e0 Compare October 5, 2023 23:53
@Pytal
Copy link
Member Author

Pytal commented Oct 6, 2023

Are the performances still good? Bart and I got caught with some limitations when we implemented our own, like img flickering and white spaces when scrolling fast.

Not as smooth as before but lighthouse performance score is still 20/22

Performance is about the same as before in Firefox but less smooth in Chrome

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 6, 2023
@Pytal Pytal merged commit 649990e into master Oct 6, 2023
39 of 40 checks passed
@Pytal Pytal deleted the enh/a11y/semantic-user-table branch October 6, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement feature: users and groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants