-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct aria-label
on action input and text field
#40662
Merged
JuliaKirschenheuter
merged 2 commits into
master
from
fix-37080_correct_aria_label_text_on_action_inputs
Oct 4, 2023
Merged
Correct aria-label
on action input and text field
#40662
JuliaKirschenheuter
merged 2 commits into
master
from
fix-37080_correct_aria_label_text_on_action_inputs
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaKirschenheuter
requested review from
susnux,
artonge,
Pytal and
ShGKme
September 27, 2023 15:29
artonge
reviewed
Sep 28, 2023
JuliaKirschenheuter
force-pushed
the
fix-37080_correct_aria_label_text_on_action_inputs
branch
from
September 28, 2023 14:00
d09a946
to
c8fef9a
Compare
Pytal
approved these changes
Sep 28, 2023
ShGKme
requested changes
Oct 2, 2023
artonge
approved these changes
Oct 2, 2023
ShGKme
approved these changes
Oct 4, 2023
JuliaKirschenheuter
force-pushed
the
fix-37080_correct_aria_label_text_on_action_inputs
branch
from
October 4, 2023 10:05
5f9b81b
to
7561056
Compare
Signed-off-by: julia.kirschenheuter <[email protected]>
JuliaKirschenheuter
force-pushed
the
fix-37080_correct_aria_label_text_on_action_inputs
branch
from
October 4, 2023 12:29
7561056
to
1431b0d
Compare
susnux
approved these changes
Oct 4, 2023
/compile amend / |
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix-37080_correct_aria_label_text_on_action_inputs
branch
from
October 4, 2023 15:29
f8ba766
to
e1bda0a
Compare
JuliaKirschenheuter
deleted the
fix-37080_correct_aria_label_text_on_action_inputs
branch
October 4, 2023 16:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before:
And the button with the arrow has an incorrect alternative text - aria-label="Clear text".
After:
Checklist