Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve di performance for cache #39889

Merged
merged 3 commits into from
Feb 13, 2024
Merged

improve di performance for cache #39889

merged 3 commits into from
Feb 13, 2024

Conversation

icewind1991
Copy link
Member

not really the cleanest, but Cache is to deeply integrated to add a ton of DI parameters without being a major pain

@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Aug 15, 2023
@icewind1991 icewind1991 force-pushed the cache-di branch 2 times, most recently from 913ed51 to 4ce0831 Compare August 16, 2023 09:04
@icewind1991 icewind1991 mentioned this pull request Aug 16, 2023
Closed
@icewind1991 icewind1991 force-pushed the cache-di branch 2 times, most recently from 39136b1 to 94bdd21 Compare August 16, 2023 14:22
@icewind1991 icewind1991 force-pushed the cache-di branch 3 times, most recently from 5c653ad to 72ee145 Compare August 28, 2023 12:21
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@icewind1991
improve di performance for cache
7a91abb 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 force-pushed the cache-di branch 2 times, most recently from 2de315a to 677a4c9 Compare February 9, 2024 12:43
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, Altahrim and nfebe and removed request for a team February 9, 2024 14:03
skjnldsv
skjnldsv requested changes Feb 10, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@icewind1991
use OCP\Server
e9d97a5 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
Copy link
Member Author

See comments

fixed

@skjnldsv skjnldsv merged commit 56640c7 into master Feb 13, 2024
156 checks passed
@skjnldsv skjnldsv deleted the cache-di branch February 13, 2024 08:40
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews performance 🚀
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@icewind1991 @AndyScherzinger @skjnldsv @blizzz