Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust add button #39884

Merged
merged 2 commits into from
Aug 16, 2023
Merged

adjust add button #39884

merged 2 commits into from
Aug 16, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Aug 15, 2023

Close #37207

Before After
image image

@szaimen szaimen added this to the Nextcloud 28 milestone Aug 15, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Aug 15, 2023

/backport to stable27

@szaimen
Copy link
Contributor Author

szaimen commented Aug 15, 2023

/compile amend /

@szaimen szaimen marked this pull request as ready for review August 15, 2023 14:30
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 15, 2023
@szaimen szaimen requested review from AndyScherzinger, susnux, Pytal, a team and artonge and removed request for a team August 15, 2023 14:30
Signed-off-by: Simon L <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@susnux
Copy link
Contributor

susnux commented Aug 15, 2023

Can we make the button look like a NcButton with primary styling? So increase the gap between icon and text and remove the border. As with a NcButton it looks like this:

image

@szaimen
Copy link
Contributor Author

szaimen commented Aug 15, 2023

How many pixel should the gap be?

@susnux
Copy link
Contributor

susnux commented Aug 15, 2023

How many pixel should the gap be?

For vue buttons it seems there is no gap but the icon is 44px by 44px.
Maybe assign to .button.new .icon:

width: 44px;
background-size: 20px 20px;

and to the button (.button.new):

padding: 0 16px 0 4px;

This should emulate the vue button styling.

@szaimen szaimen force-pushed the enh/37207/adjust-add-button branch from d3a53cf to 7d51257 Compare August 16, 2023 10:51
@szaimen
Copy link
Contributor Author

szaimen commented Aug 16, 2023

/compile amend /

@szaimen szaimen requested review from susnux and removed request for susnux August 16, 2023 10:52
Signed-off-by: Simon L <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@szaimen szaimen enabled auto-merge August 16, 2023 11:29
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice! :)

@szaimen szaimen merged commit 12805ee into master Aug 16, 2023
38 checks passed
@szaimen szaimen deleted the enh/37207/adjust-add-button branch August 16, 2023 15:11
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen
Copy link
Contributor Author

szaimen commented Aug 16, 2023

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen szaimen restored the enh/37207/adjust-add-button branch August 16, 2023 15:42
@szaimen szaimen deleted the enh/37207/adjust-add-button branch August 16, 2023 15:46
@szaimen
Copy link
Contributor Author

szaimen commented Aug 16, 2023

#39915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload/add button style and discoverability
4 participants