-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust add button #39884
adjust add button #39884
Conversation
/backport to stable27 |
30f00ed
to
2cbce95
Compare
/compile amend / |
Signed-off-by: Simon L <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
2cbce95
to
cec4986
Compare
How many pixel should the gap be? |
For vue buttons it seems there is no gap but the icon is 44px by 44px. width: 44px;
background-size: 20px 20px; and to the button ( padding: 0 16px 0 4px; This should emulate the vue button styling. |
d3a53cf
to
7d51257
Compare
/compile amend / |
Signed-off-by: Simon L <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
7d51257
to
7926b63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice! :)
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Close #37207