Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encode basename in restore action #39842

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 12, 2023

Summary

As per https://xhr.spec.whatwg.org/#the-setrequestheader()-method and https://infra.spec.whatwg.org/#byte-sequences the header value must be in the range 0x20 (SP) to 0x7E (~) hence we need to encode everything else.

TODO

  • CI

Checklist

@kesselb kesselb self-assigned this Aug 12, 2023
@kesselb kesselb added bug 3. to review Waiting for reviews labels Aug 12, 2023
@kesselb kesselb added this to the Nextcloud 28 milestone Aug 12, 2023
@kesselb
Copy link
Contributor Author

kesselb commented Aug 12, 2023

/backport to stable27

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be many locations where this would be needed then 🤔

@kesselb
Copy link
Contributor Author

kesselb commented Aug 12, 2023

There might be many locations where this would be needed then

I guess ;)

@kesselb kesselb force-pushed the encode-filename-trashbin-restore branch from 60ffb68 to 7183e3d Compare August 25, 2023 10:53
@kesselb kesselb merged commit 5d9b84d into master Aug 25, 2023
39 checks passed
@kesselb kesselb deleted the encode-filename-trashbin-restore branch August 25, 2023 15:08
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@kesselb
Copy link
Contributor Author

kesselb commented Aug 25, 2023

stable27: #39842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants